Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node bindings release workflow #1013

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Aug 29, 2024

Summary

The node bindings release workflow stopped working due to some install issues. To fix these, 2 changes were made:

  • Added sudo apt-get update before installing some linux tools to ensure latest package information
  • Added choco upgrade visualstudio2022enterprise before installing visualstudio2022buildtools on windows machines (see this comment for details)

@rygine rygine requested a review from a team as a code owner August 29, 2024 15:43
@rygine rygine merged commit 395f7e2 into main Aug 29, 2024
2 checks passed
@rygine rygine deleted the rygine/fix-node-release-workflow branch August 29, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants